Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
==========================================
+ Coverage 52.37% 52.50% +0.13%
==========================================
Files 26 26
Lines 3729 3733 +4
Branches 747 748 +1
==========================================
+ Hits 1953 1960 +7
+ Misses 1472 1469 -3
Partials 304 304 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
why: tmux stores user options as strings, but reading values such as "123" or "off" changed their types and broke round trips. what: - Preserve @ values in single and bulk option reads across scopes - Cover inherited reads and retain built-in option conversions - Document string results and explicit conversion for callers
why: Keep development and CI linting on the same Ruff release, including corrected f-string conversions and safer lint fixes. what: - Raise Ruff floors in the development and lint dependency groups - Lock Ruff 0.17.3 with its published source and wheel hashes Ruff release notes: https://github.com/astral-sh/ruff/releases/tag/0.17.2 https://github.com/astral-sh/ruff/releases/tag/0.17.3
why: Contributors need the lint-tool requirement alongside other development environment changes. what: - Document the Ruff 0.17.3 minimum for development and lint checks
tony
force-pushed
the
fix/759-user-options
branch
from
November 7, 2026 02:00
0d8c9fe to
55752f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An option such as
@count="123"previously read back as the integer123, so a user-supplied identity stopped comparing equal to its stored value.show_option()andshow_options()now return"123","on","off"and the empty string unchanged. This follows tmux 3.2a's user-option string storage; the compatibility floor remains 3.2a.The correction covers server, session, window and pane options, global session/window defaults, and named inherited reads. Runnable guide and migration examples show the corrected value and explicit conversion when an application needs a number or boolean.
Test plan
just build-docspass.0d8c9fea8c2b3b6d994d95b6f97ea9fdf64c247eremain FAIL: tmux 3.2a and 3.3a pass; 3.4, 3.5, 3.6, 3.7a and 3.7b fail. Both CodeQL analyses and the aggregate pass; codecov/project fails. The existing cached-binary ABI problem is tracked by tmux(fix[3.8]): Support hooks and terminal fixtures #825. The development-tmux job reports success despite failing to start pytest because of that ABI problem; it is not a passing test run. Maintainer review remains pending.Addresses #759. The failed mandatory full-suite gate keeps delivery partial; maintainer review remains pending.