Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 52.37% 52.52% +0.15%
==========================================
Files 26 27 +1
Lines 3729 3779 +50
Branches 747 757 +10
==========================================
+ Hits 1953 1985 +32
- Misses 1472 1489 +17
- Partials 304 305 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 1, 2026
tony
added a commit
that referenced
this pull request
Nov 1, 2026
why: Readers need product notes before adopting this change. what: - Describe retained pane observations in the unreleased changelog - Reference PR #810
tony
force-pushed
the
rmux-py-pane-observation
branch
from
November 1, 2026 13:51
041e23d to
d794cc8
Compare
why: Consumers need capture evidence that remains readable after redraw or pane removal. what: - Copy decoded text and command provenance into a frozen standalone value - Preserve backend routing and reject failed or oversized captures - Document sampled identity limits and verify retained text with an owned producer
why: Readers need product notes before adopting this change. what: - Describe retained pane observations in the unreleased changelog - Reference PR #810
why: A backend can change its mutable output after size validation, leaving an observation with more retained text than its admission limit permits. what: - Copy decoded lines once before measuring and retaining them - Cover native custom routing, redraw, pane removal and server removal - Document observation fields and qualify producer signal semantics
why: Keep development and CI linting on the same Ruff release, including corrected f-string conversions and safer lint fixes. what: - Raise Ruff floors in the development and lint dependency groups - Lock Ruff 0.17.3 with its published source and wheel hashes Ruff release notes: https://github.com/astral-sh/ruff/releases/tag/0.17.2 https://github.com/astral-sh/ruff/releases/tag/0.17.3
why: Contributors need the lint-tool requirement alongside other development environment changes. what: - Document the Ruff 0.17.3 minimum for development and lint checks
tony
force-pushed
the
rmux-py-pane-observation
branch
from
November 7, 2026 02:17
398322f to
ce4abc5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaneObservation.capture(pane)retains sampled pane text after redraw or removal. It copies lines and the actual command argv into a frozen standalone value, retaining capture selection and the controller's monotonic interval without live pane/server references.The call uses the supplied
pane.cmdroute and refuses failed or oversized captures instead of returning a successful empty value. The decoded-text admission limit counts Python Unicode code points and LF, after the existing transport returns. It is not a transport memory cap or an added deadline. Pane lifetime remains explicitly unknown with the legacy handle. Lines are frozen before their retained size is measured, so a backend mutation cannot bypass the decoded-text admission check.For example,
saved = PaneObservation.capture(pane, start=-20)retainssaved.textandsaved.commandafter redraw or removal. Its range and joined-line selection follow tmux 3.2a capture semantics.This is the independent pane-value slice of #370 and #584 under #629, based on current master with sibling branches absent. PR #568 still retains mutable nested lists/dicts; #587/#590 cover inherited object graphs and #613 covers mutable ASCII rendering and pytest integration. Their wider work remains open. This slice adds no engine classes, object graph, serializer or persistent recording.
Validation:
just build-docsand rendered API/changelog links pass.398322f0e7442b37968add264157f15a621bd363remain FAIL: tmux 3.3a pass; 3.2a, 3.4, 3.5, 3.6, 3.7a, 3.7b fail. CodeQL passes; codecov/project fails. The development-tmux job allows failures and is not full-suite pass evidence. The 3.2a failure is the existing capture test accepting an echoed, unexecuted completion marker; the other stable failures include the cached-binary ABI problem tracked in tmux(fix[3.8]): Support hooks and terminal fixtures #825.Retained values remain readable while referenced, including after server loss; process exit loses the in-memory value. Captures cannot establish omitted-output continuity, hidden terminal state, or arbitrary-shell completion. A cooperating producer's signal establishes only its application-defined milestone. No macOS work or minimum-version change is included; existing support remains unchanged.
Refs #370 and #584. Keep full object graphs, serialization and wiring retained observations into every failure open under those canonical issues. The failed mandatory full-suite gate keeps delivery partial; maintainer review remains pending.