Skip to content

Use proposed PR to fix false positive i18n warnings - #318

Merged
rffontenelle merged 2 commits into
mainfrom
test-fix-false-positive-i18n-warnings
Nov 17, 2026
Merged

rffontenelle merged 2 commits into
mainfrom
test-fix-false-positive-i18n-warnings

Conversation

@rffontenelle

Copy link
Copy Markdown
Collaborator

CPython bumped Sphinx to version 9.1.1 and this is causing massive false-positive in our CI logs, which also broke Telegram notification (because it exceeds 4096 chars and we don't handle messages exceeding this limit).

Using @m-aciek's yet unmerged PR is a good workaround to the above issue as well as is an opportunity to test the proposed code.

We're running make -C cpython/Doc venv to install CPython's exact docs build environment. Replacing Sphinx version from cpython/Doc/requirements.txt fails because pylock.toml is set with a specific Sphinx. A nasty, yet simple workaround is install the desired unmerged branch right after confirming the Sphinx 9 was installed. If Sphinx<9 then nothing is done, so this should work for every CPython branch.

@rffontenelle
rffontenelle merged commit ee83348 into main Nov 17, 2026
20 of 26 checks passed
@rffontenelle
rffontenelle deleted the test-fix-false-positive-i18n-warnings branch November 17, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant