Skip to content

fix(ui): replace array index React keys in select and table of contents - #9336

Open
RedaMG1 wants to merge 3 commits into
nodejs:mainfrom
RedaMG1:fix/ui-stable-react-keys-9333
Open

RedaMG1 wants to merge 3 commits into
nodejs:mainfrom
RedaMG1:fix/ui-stable-react-keys-9333

Conversation

@RedaMG1

@RedaMG1 RedaMG1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #9333.

Summary

Remove three @eslint-react/no-array-index-key warnings in the Node.js website's React components.

  • Use stable group values as fallback keys in Select and StatelessSelect.
  • Use heading depth and text as a fallback key in TableOfContents.

Verification

  • Verified that only the three affected components were modified.
  • Confirmed the index-based keys were replaced.
  • Full ESLint and UI tests have not been run locally.

@RedaMG1
RedaMG1 requested a review from a team as a code owner November 16, 2026 13:21
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Nov 16, 2026 1:22pm UTC

Request Review

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution, @RedaMG1 but this change isn't needed. We're not facing any actual current issue with the current approach, despite indeed, these being non-unique keys.

This branch was successfully deployed

1 active deployment
Preview — ce59f87f Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter warning @eslint-react/no-array-index-key after Dependabot PR #9278

2 participants