Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8529 +/- ##
==========================================
- Coverage 74.27% 74.26% -0.01%
==========================================
Files 104 104
Lines 8847 8853 +6
Branches 328 328
==========================================
+ Hits 6571 6575 +4
- Misses 2274 2276 +2
Partials 2 2 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR replaces the static SVG image of the Node.js release schedule with a dynamically generated component that fetches schedule data from GitHub and renders it using the lts library.
Key Changes:
- Adds a new
ReleaseScheduleReact component that dynamically generates the schedule visualization - Introduces a data provider to fetch release schedule JSON from the Node.js Release repository
- Replaces the static image reference in the MDX file with the new component
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds lts package from GitHub repository along with its dependencies (d3, jsdom, svg2png, etc.) |
| apps/site/package.json | Declares the lts dependency from GitHub repository |
| apps/site/next.constants.mjs | Adds RELEASE_SCHEDULE_URL constant pointing to schedule.json |
| apps/site/next-data/generators/releaseSchedule.mjs | Creates fetch function for release schedule data |
| apps/site/next-data/providers/releaseSchedule.ts | Provides cached access to release schedule data |
| apps/site/components/Releases/ReleaseSchedule/index.tsx | Implements the ReleaseSchedule component with SVG generation |
| apps/site/mdx/components.mjs | Registers ReleaseSchedule component for MDX usage |
| apps/site/pages/en/about/previous-releases.mdx | Replaces static image with ReleaseSchedule component |
| apps/site/next-env.d.ts | Updates TypeScript reference path (appears unintentional) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
|
(I'll fix the comparator to comment on fork PRs) |
|
@araujogui do we have a path forward? |
I'm waiting for the upstream to get merged. |
I pinged some folxs on Slack. |
|
@araujogui can you rebase? |
e732e4d to
931aabb
Compare
PR SummaryMedium Risk Overview Adds a new Reviewed by Cursor Bugbot for commit 387cd38. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f25ebd. Configure here.
|
@araujogui do you think we should close this per the new release schedule, or could it be adapted/resurrected? |
I think #8101 is still a valid issue but given the release team's current workload and competing priorities, perhaps we should consider creating our own package instead of relying on |
|
The release team can use mermaid diagrams instead of SVGs in their repositories, as suggested at nodejs/Release#1119 (comment). |

Description
Create new release schedule component
Validation
Related Issues
Fixes #8101
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.