Repository navigation
Conversation
Resolve the exposed digest options against provider descriptors and construct UTF-8 or octet strings according to their advertised types. Keep binary values intact for octet strings and reject NUL bytes for UTF-8 strings. Share hash initialization and one-shot input/output handling while retaining the plain digest fast paths and XOF length checks. Probe RSA implicit rejection without changing its context. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Build exposed MAC parameters from one option table and their advertised types. Keep binary octet values and terminated UTF-8 strings. Share sign/verify initialization and replace padding and salt length presence flags with optional values. Pass context parameters during initialization and retain backend-specific handling. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Cover binary and empty digest customization, incompatible parameter types, and MAC descriptor selection with a shared test provider. Check UTF-8 termination for byte inputs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
Use the same error as createHash() when outputLength differs from a fixed-size digest's length. Preserve acceptance of the exact length. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Document which digest and MAC options apply and how output lengths work. Clarify signature contexts and distinguish required parameters from optional defaults in Web Crypto. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
crypto-settable-params
branch
from
November 17, 2026 23:45
342c5fe to
b61e0b5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #67565 +/- ##
==========================================
- Coverage 90.71% 90.70% -0.01%
==========================================
Files 801 801
Lines 280705 280650 -55
Branches 54168 54152 -16
==========================================
- Hits 254640 254573 -67
- Misses 16247 16253 +6
- Partials 9818 9824 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use OpenSSL's settable parameter descriptors to select the supported types for digest and MAC options exposed by Node.js. Digests that accept
customizationas an octet string now receive the original bytes, including embedded NULs.Share hash initialization and sign/verify setup, and check RSA implicit rejection support without setting the parameter.
Clarify which options apply in the crypto and Web Crypto docs.