Repository navigation
tools: apply http lint rule to lib/internal/http - #67529
Open
Ethan-Arrowood wants to merge 1 commit into
Open
Ethan-Arrowood wants to merge 1 commit into
Ethan-Arrowood wants to merge 1 commit into
Conversation
The `lib/_http_*.js` files moved to `lib/internal/http/` recently. But the ESLint config still only listed the old paths. The moved files lost the "Do not use prototype primordials in this file" check that other HTTP hot paths have. This change adds `lib/internal/http/*.js` to that rule list. The files already comply so no other changes are needed. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
efekrskl
approved these changes
Nov 16, 2026
Collaborator
bjohansebas
approved these changes
Nov 16, 2026
aduh95
approved these changes
Nov 17, 2026
richardlau
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lib/_http_*.jsfiles moved tolib/internal/http/recently. But the ESLint config still only listed the old paths. The moved files lost the "Do not use prototype primordials in this file" check that other HTTP hot paths have.This change adds
lib/internal/http/*.jsto that rule list. The files already comply so no other changes are needed.Refs: #58535
AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.