Skip to content

test: ignore ECONNRESET in test-gc-net-timeout - #67514

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:unflake-test-gc-net-timeout
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:unflake-test-gc-net-timeout

Conversation

@aduh95

@aduh95 aduh95 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Before this change:

$ ./tools/test.py --repeat 999 test/parallel/test-gc-net-timeout.js               
[00:34|% 100|+ 948|-  51]: Done

After this change:

$ ./tools/test.py --repeat 999 test/parallel/test-gc-net-timeout.js               
[00:38|% 100|+ 999|-   0]: Done    

I've asked a coding agent on what might be the cause:

My guess at the cause: the listen queue fills up and macOS resets a connection still waiting there, where Linux would drop the SYN and let the client retry. I haven't confirmed that in the XNU source.
A reset socket is still destroyed and garbage-collected, so countGC === count still holds.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (1a36610) to head (0909ef0).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67514      +/-   ##
==========================================
+ Coverage   90.67%   90.68%   +0.01%     
==========================================
  Files         799      799              
  Lines      280244   280244              
  Branches    54124    54123       -1     
==========================================
+ Hits       254105   254152      +47     
+ Misses      16275    16227      -48     
- Partials     9864     9865       +1     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added flaky-test Issues and PRs involving tests that fail intermittently in CI. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 16, 2026
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants