Repository navigation
Conversation
Remove ecdh.setPublicKey(). ECDH only requires a private key and the other party's public key to compute a shared secret, and ecdh.setPrivateKey() already derives and sets the associated public key. The native ECDH setPublicKey binding is removed as well. diffieHellman.setPublicKey() is unaffected. This has been a runtime deprecation since v25.0.0 and a documentation-only deprecation since v5.2.0. Refs: nodejs#58620 Refs: nodejs#3511 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67493 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 799 799
Lines 280245 280225 -20
Branches 54125 54116 -9
=======================================
+ Hits 254100 254104 +4
+ Misses 16280 16275 -5
+ Partials 9865 9846 -19
🚀 New features to boost your workflow:
|
|
This pull request has conflicts with its base branch, removing the |
Commit Queue failed
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
Remove ecdh.setPublicKey(). ECDH only requires a private key and the other party's public key to compute a shared secret, and ecdh.setPrivateKey() already derives and sets the associated public key. The native ECDH setPublicKey binding is removed as well.
diffieHellman.setPublicKey() is unaffected.
This has been a runtime deprecation since v25.0.0 and a documentation-only deprecation since v5.2.0.
Refs: #58620
Refs: #3511