Skip to content

build: avoid /docs/api and /docs/doc/api upload - #12957

Closed
rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:docs-rsync
Closed

rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:docs-rsync

Conversation

@rvagg

@rvagg rvagg commented May 11, 2017

Copy link
Copy Markdown
Member

Fixes problem of having /docs/api and /docs/doc/api directories in our distributions, caused by a double (or more) build on CI server prior to promotion as reported and discussed in #12833.

scp -pr out/doc/ server:.../docs/ first sees a missing /docs/ directory so puts the out/doc/ contents into /docs/, second pass it sees an existing directory so makes a new /docs/doc/ directory for the upload.

This fix ensures the directory exists initially and then does an scp of the contents of the out/doc/ directory rather than the directory itself.

Needs to be backported to all active release lines once confirmed working.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants