Skip to content

Merge every published port manifest into versions.json, loudly - #29

Merged
tony merged 1 commit into
mainfrom
manifest-merge-loud
Sep 27, 2026
Merged

tony merged 1 commit into
mainfrom
manifest-merge-loud

Conversation

@tony

@tony tony commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Part of #27. The shell deploy copied each manifest/<port>.json with 2>/dev/null || true under a role that could not read manifest/*, so the last deploys each logged merge-version-manifests: merged 0 published port fragment(s) (for example run 36317927860) and ports' versions and defaults never reached versions.json.

  • Sync the whole manifest/ prefix instead of a hard-coded port list. A port that never published has no file; a manifest that exists but cannot be read now fails the deploy.
  • List the merged ports in the job summary.

The shell role's s3:GetObject on manifest/* is applied in the infrastructure Terraform (a targeted re-plan shows no changes). Dry run against the ten live manifests: merged 10 published port fragment(s), every port's default present.

@tony
tony marked this pull request as ready for review September 27, 2026 17:27
why: The shell deploy copied each manifest/<port>.json with
`2>/dev/null || true` under a role that could not read manifest/*, so
every copy failed silently and the last deploys logged "merged 0
published port fragment(s)": ports' versions and defaults never reached
versions.json. The loop also duplicated the port list.

what:
- Sync the whole manifest/ prefix; a port that never published has no
  file, while a manifest that cannot be read fails the deploy
- List the merged ports in the job summary
- The workflow contract test asserts the sync and that nothing in the
  merge step silences an error; it fails against the old loop
- Merging the ten live manifests locally gives "merged 10" and every
  port's default; the shell role's read grant is applied in Terraform
@tony
tony force-pushed the manifest-merge-loud branch from 63e7072 to 3f78af0 Compare September 27, 2026 17:32
@tony
tony merged commit cf79af7 into main Sep 27, 2026
8 checks passed
@tony
tony temporarily deployed to docs-preview-cleanup September 27, 2026 18:08 — with GitHub Actions Inactive
tony added a commit that referenced this pull request Nov 19, 2026
…bility directories

why: The Common Lisp reference pages for the Session, Window and Pane classes
cannot show the "What is on here" capability directory until the model carries
the prose it is built from. libtmux-lisp#28 adds the three directories and
#29 makes the shipped examples start the tmux on PATH, so the guides and
examples the site quotes changed with it. Both are on master as merge commits,
so the revision stays reachable. The committed model, guide cache and manifest
still described a29c6b96e, the head of the client directory pull request.

what:
- Pin Common Lisp to libtmux/libtmux-lisp@9f364931a and regenerate its model
  and path data (exported with SBCL 2.6.10 and ASDF 3.3.7, the runtime
  recorded in the previous model, from a clean clone with the locked
  dependencies), tmux usage, source cache, guide cache, manifest packages and
  cached examples with the repository's generators; the mention index and the
  sidebar sidecar come out unchanged
- Adopt the source change between the pins: the model keeps 293 symbols with
  none added or removed. The Session, Window and Pane classes gain the
  directory, 9 rows each, and 25 declarations move to new lines because
  model.lisp grew above them; the exporter digest and four of its 55 native
  inputs (libtmux.asd, src/model.lisp, src/options-catalog.lisp,
  tools/documentation.lisp) are the only other model differences. #29 changes
  no file under src/
- Keep every reviewed tmux usage claim: all of them hold at the new revision,
  so only the usage file's revision binding changes
- Take the five changed guides into the guide cache: the README, the REPL
  tutorial, the verification guide and the two workspace guides now run
  programs with `sbcl --script` where they ran `tools/lisp.sh`, the tutorial
  worker is worker.lisp, the workspace command is tools/workspace-cli.lisp,
  which replaces bin/libtmux-workspace, and the tutorial runner starts the
  tmux on PATH instead of offering another binary
- Move the workspace example cached for the landing page to the new revision;
  its bytes are unchanged
- Link all eleven files of the examples index at the new revision, name
  worker.lisp for the tutorial worker, run the sample with `sbcl --script`
  and describe the quickstart as starting its own isolated daemon, which it
  does now that it no longer reads a socket from the environment; the index
  still has seven programs and four support files
- Expect the directories of Session (9 rows, 54 references), Window (9, 55)
  and Pane (9, 58) in the directory test
- Not changed here: the Workspace page, the inventory entry and the source
  link for the workspace command still name tools/lisp.sh and
  bin/libtmux-workspace, which the source no longer has, so the manifest
  reader no longer records the script unit
- Leave the landing quickstart and the Core player recording at the revision
  where they were recorded: they still show the socket-from-environment
  program, and re-recording the quickstart is a separate step

Source refs: libtmux/libtmux-lisp master
9f364931a38fafce7bfea7cb4f7e6b32ef49ebb4 (#28 and #29), previous pin
a29c6b96e1c78501dff5073b538ae3180b0e63e3; merge commits at
libtmux/libtmux-lisp@e3c5380
and
libtmux/libtmux-lisp@9f36493.
tony added a commit that referenced this pull request Nov 19, 2026
… and re-record it

why: The landing page program and its Core player recording were the
quickstart at libtmux-lisp 99874b44d, which reads LIBTMUX_SOURCE,
LIBTMUX_PROGRAM and LIBTMUX_EXAMPLE_SOCKET, loads libtmux.asd itself and
connects to a server the page's own setup command starts. At 9f364931a
(libtmux-lisp#29) examples/quickstart.lisp loads tools/load.lisp, starts the
daemon it uses with `libtmux:with-daemon` and stops it by its process id, so
a reader needs no variable, no socket and no tmux command of their own. The
recorder's step map described the older program: it expected a running server
before the first call and a `kill-server` at the end.

what:
- Move the landing example to libtmux/libtmux-lisp@9f364931a (tree 3b1f1d14f).
  The program is the committed examples/quickstart.lisp, except that its two
  lines of 82 and 95 columns are wrapped, because every view of a landing
  program must fit 80 columns; the page's file is 52 lines
- Rebuild the views: concise and errors are the program without its closing
  `pending-daemon-cleanups` assertion, and cleanup is the whole program. Say
  in the page's notes that `observed-value` already unwraps a failed
  observation and that `with-daemon` stops the daemon and removes its socket
  directory on every exit
- Replace the commands: fetch the checkout at that revision and install its
  toolchain, then `cd source` and `mise exec -- sbcl --script
  examples/quickstart.lisp`; the page no longer starts a server or exports a
  variable
- Recorder: a recipe may list `inPlaceFirst`, the flags that begin an
  invocation the shim runs as tmux itself untraced. libtmux-lisp starts its
  daemon as `tmux -D -f /dev/null -S <socket>`, which ends in a path that
  differs on every run, so `inPlace` (the last word) cannot name it, and a
  wrapper process in between would make the daemon a stranger to the library
  that stops it by process id
- Lisp recipe: drop the setup that started the server, run the program from a
  directory that links the checkout's tools/ and holds the displayed copy, give
  it a TMPDIR of its own where the recorder looks for the daemon's socket
  (`libtmux-lisp-daemon-<six characters>`), put the pinned asdf.lisp first on
  PATH so a mise shim of the same name is not read as ASDF, and map the calls
  of the new program: the daemon's startup probes belong to the first call,
  the pure reads of its two-call line to one step, and `with-daemon` ends the
  run with a `stop-daemon` step on the `(daemon)` line, which stops the server
  and sends no command
- Re-record the Core player at 9f364931a on tmux 3.7c: 15 steps, printed
  output equal to the page's, `--check` passing on tmux 3.7c and 3.3a
- Record the verification of the new program in the home fixture: digests of
  the four views, the source tree and the commands, run on tmux 3.3a, 3.7c
  and 3.8. check-example-prose.py cannot run this program, because the PATH
  shim it puts first is a script and libtmux-lisp refuses a script as the
  daemon's program; each of the 12 runs (four views on three versions)
  executed the page's two commands with the displayed view written over the
  checkout's file, a private TMPDIR, and then required the four printed lines,
  exit status 0, no daemon process and no file left
- Update the recipe and recording tests to the new program, and move the test
  of the player's "server is running" note to the Haskell recording, the only
  other one that starts with a server
- Not changed here: the Capture pane output example and the attaching guide
  still read LIBTMUX_PROGRAM to choose a tmux binary

Source ref: libtmux/libtmux-lisp master
9f364931a38fafce7bfea7cb4f7e6b32ef49ebb4 (#29), previous landing revision
99874b44dbe29b3651597a5debbacccde235d96c.
tony added a commit that referenced this pull request Nov 19, 2026
…ault tmux

why: Capture pane output and Attaching to tmux told a reader to set
LIBTMUX_PROGRAM to choose a tmux binary. That variable is the libtmux-lisp
repository's example-runner setting and means nothing to a reader. Since
libtmux-lisp#29 (9f364931a) the shipped programs stop reading it and run the
`tmux` on PATH, which is also what `open-client` uses when `:program` is
omitted; 0f9da93, the revision both pages run, already has that default.

what:
- capture.lisp: drop the `program` binding and `:program`; the pane signals
  its `wait-for` channel with plain `tmux` instead of a CAPTURE_TMUX
  variable, because the pane inherits the program's PATH
- connect.lisp: drop `*program*` and both `:program` arguments
- Replace the sentences that named the variable with "The program runs the
  `tmux` on your `PATH`", and say why the pane's `tmux` is the one the
  program started
- Update the displayed-program digests, the tmux versions and the
  verification checks in capture-examples.json and attach-examples.json;
  the pinned revision and the setup commands do not change
- Not changed: the program's own `LIBTMUX_SOCKET_PATH` input in the attach
  guide, which is a documented input of the displayed program

Verification: check-example-prose.py --example capture and --example attach
(--port lisp) ran each page's displayed setup and program at 0f9da93 on tmux
3.3a, 3.7c and 3.8, with a symlink to that build first on PATH. All six runs
exited 0, printed `libtmux capture ready` or `work`, and left no
/tmp/libtmux-lisp-* directory or tmux server. A probe copy of capture.lisp
printed the pane's resolved `tmux` as the selected build on each version; the
attach guide's borrowed-server path printed `work`, left the server running
and exited 0 on each version. The focused vitest files and
check-example-blocks and check-example-indentation passed.

Source ref: libtmux/libtmux-lisp master
9f364931a38fafce7bfea7cb4f7e6b32ef49ebb4 (#29).

This branch was previously deployed

2 inactive deployments
docs-preview-cleanup — 3f78af0e Deployed Sep 27, 2026 by tony via cleanup #23
docs-preview — 3f78af0e Deployed Sep 27, 2026 by tony via publish-preview / publish #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant