Repository navigation
Backfill included_presets on public files during deploy - #6458
Open
rtibblesbot wants to merge 1 commit into
Open
rtibblesbot wants to merge 1 commit into
rtibblesbot wants to merge 1 commit into
Conversation
Adds backfill_public_file_included_presets, run from deploy-migrate, to set included_presets on non-supplementary renderable kolibri_public files in batches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
marked this pull request as ready for review
November 19, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
included_presetsstore NULL, which/importmetadata/returns.make deploy-migrate, batch-fills them with the value publish would write.References
Fixes #6456. Precedent: #6171.
Reviewer guidance
Suggested review: Full code review.
Engineer review
fe88cd4cccan reintroduce NULL masks (contentcuration/kolibri_public/utils/mapper.py:91).If-Modified-Sincerequests can return 304 for stale NULL masks until the public metadata timestamp advances (contentcuration/kolibri_public/views.py:63).contentcuration/kolibri_public/management/commands/backfill_public_file_included_presets.py:15).Engineer evidence
Not run against Postgres outside CI's backend tests.
kolibri_public_file?/importmetadata/get 304 on stale NULLs until a public channel is next mapped, as after the modality backfill.AI usage
Used Claude Code to write the command, its tests and the
deploy-migrateentry following the modality backfill. Verified with code review against the publish rule andmake -n deploy-migrate.Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
WAITING · on a reviewerLast updated: 2026-11-19 23:21 UTC