Skip to content

Bump KDS to 5.10.1 and close the paste menu when it collapses into More - #6457

Open
AlexVelezLl wants to merge 2 commits into
learningequality:unstablefrom
AlexVelezLl:kds-5.10.1
Open

AlexVelezLl wants to merge 2 commits into
learningequality:unstablefrom
AlexVelezLl:kds-5.10.1

Conversation

@AlexVelezLl

Copy link
Copy Markdown
Member

Summary

  • Bumps KDS to 5.10.1, which fixes the "Response type" select not closing on outside clicks in the exercise editor, and brings KDropdownMenu's RTL and viewport fixes. No Studio changes needed for these.
  • Closes the paste menu when its button collapses into the toolbar's More menu, using the now-public closePopover(). The More button moves into its own component so the toolbar can tell which groups collapsed.

References

Reviewer guidance

  1. Exercise editor: open "Response type", then click elsewhere in the question card. The select closes.
  2. Rich text editor: open the paste chevron menu, then narrow the window until paste collapses into More. The menu closes.

AI usage

I used Claude Code to check which KDS 5.10.1 fixes needed Studio changes, implement the paste menu fix with its test, and verify both fixes in the browser. I chose the approach of reading the collapsed groups from the slot, and reviewed and edited the code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AlexVelezLl
AlexVelezLl marked this pull request as ready for review November 19, 2026 15:59
@AlexVelezLl
AlexVelezLl requested review from a team, leq-bot and rtibblesbot November 19, 2026 15:59

rtibblesbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Waiting for changes

Outcome: reviewed bd53a2f

Last updated: 2026-11-19 22:22 UTC

@rtibblesbot rtibblesbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6457: closing the paste menu on collapse works. QA confirmed it at the 670→660px breakpoint. The new test drives a real toolbar collapse.

  • suggestion: focus drops to <body> when the menu closes on collapse (inline).
  • nitpick: the moved flatten comment in ToolbarMoreButton.vue makes a false claim (inline).
  • CI pending.
  • Manual QA covered paste/More menus across resizes, keyboard, RTL, and other KDS dropdowns after the 5.10.1 bump. No regressions found.
  • The KSelect click-outside fix (#6325) holds.

Next step: Needs a light-touch code review by a human engineer, then manual QA.

  • User-visible files changed: contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/EditorToolbar.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/PasteDropdown.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/ToolbarMoreButton.vue.
  • Narrow the Questions editor with the paste menu open and check the menu closes and focus lands somewhere visible.
  • Spot-check KDS dropdowns after the 5.10.1 bump (open, close on outside click and Escape).
QA captures (44)

Edit an exercise question and change its "Response type" select — open it, click elsewhere in the question card and outside the card, confirm it closes each time, then pick a new type and confirm the choice sticks

Step Screenshot
Keyboard after enter Keyboard after enter
Question editor closed Question editor closed
Select open Select open
Type changed multiple choice Type changed multiple choice
1-response-type-select.webm

Open the rich text editor's paste chevron menu, then narrow the window until paste collapses into More — the menu closes, the chevron's aria-expanded is false, no orphaned menu remains on the page; widen again and confirm the paste button and its menu reopen and paste normally

Step Screenshot
Collapsed more menu open Collapsed more menu open
Paste menu open wide Paste menu open wide
Paste menu reopened after widen Paste menu reopened after widen
2-narrow-closes-paste-menu.webm
2-widen-reopen-and-paste.webm
page@4cf67b10dcd72ac3ebfb1f05773616e6.webm

Narrow the rich text editor toolbar until several groups collapse, open More and apply formatting from it (bold, list, script, clear formatting) — active-state highlighting, unavailable items disabled, dividers between groups, editor content updates, focus returns to the editor

Step Screenshot
More menu list script active More menu list script active
More menu open 480 More menu open 480
More menu strong active More menu strong active
3-more-menu-formatting.webm

From the More menu, use the collapsed paste options and an insert tool (image, math or link) — each opens or acts the same as its inline toolbar button, and the More menu closes afterwards

Step Screenshot
Image from more Image from more
Image inline 1400 Image inline 1400
Math from more Math from more
Math inline 1400 Math inline 1400
Math inserted from more Math inserted from more
More menu open More menu open
Paste from more result Paste from more result
4-keyboard-math-from-more.webm

Resize the editor window back and forth across the overflow breakpoints repeatedly — More appears only when groups collapse and disappears when all fit, its options always match the hidden groups, and the inline paste menu still opens after the button reappears

Step Screenshot
More gone at 1400 More gone at 1400
More open after widen 900 More open after widen 900
Paste menu reopens after resize Paste menu reopens after resize
5-resize-cycles.webm

Drive the toolbar and More menu by keyboard only — roving tabindex reaches the More button, Enter/Arrow keys open and move through its options, Escape closes it and returns focus to the More button, collapsed paste menu is never focusable

Step Screenshot
More button focused More button focused
More menu open keyboard More menu open keyboard
6-keyboard-more-menu.webm

Switch Studio to an RTL language and open the paste chevron menu and the More menu near the toolbar's edges — menus align to the correct side, stay inside the viewport and the chevron icon rotates when expanded

Step Screenshot
Rtl more menu 400 Rtl more menu 400
Rtl more menu 400x500 scrolled Rtl more menu 400x500 scrolled
Rtl more menu 690 Rtl more menu 690
Rtl paste menu 1400 Rtl paste menu 1400
Rtl paste menu 690 Rtl paste menu 690

Open the toolbar's format dropdown and other KDS dropdown menus in the channel editor (node context menu, channel list card menu) — they open in the viewport, close on outside click and Escape, and their actions still run after the KDS 5.10.1 bump

Step Screenshot
Channel card menu flips up Channel card menu flips up
Channel card menu open Channel card menu open
Editor view menu open Editor view menu open
Format dropdown open Format dropdown open
Format dropdown short viewport Format dropdown short viewport
Node context menu open Node context menu open
Node options menu open Node options menu open
Share token dialog Share token dialog
8-format-dropdown-open-close.webm

Written by rtibblesbot, an LLM-based coding agent.

Copy link
Copy Markdown
Contributor

I was unable to complete this task after multiple attempts. Manual review and intervention may be needed.

@rtibblesbot rtibblesbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6457: both prior findings are resolved. Manual QA found one new focus loss, left as a suggestion.

CI passing. Manual QA covered collapse/restore, keyboard use of More, two editors open at once, and RTL. It also covered KDropdownMenu menus outside the editor after the KDS bump. Its only axe violations already exist on the base branch.

Prior-finding status

RESOLVED — contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/PasteDropdown.vue:76 — Focus drops to <body> when an open paste menu closes because its button collapsed
RESOLVED — contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/ToolbarMoreButton.vue — "other component-only actions are skipped" comment is false

Next step: Needs a full code review by a human engineer, then manual QA once that reviewer sets Needs QA.

  • User-visible files changed: contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/EditorToolbar.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/PasteDropdown.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/ToolbarMoreButton.vue.
  • Confirm the kolibri-design-system 5.10.1 bump brings in no KDS behaviour changes beyond KSelect's outside-click handling.
  • Check toolbar focus while resizing in both directions: More takes focus when groups collapse, and focus is restored when More goes away.
QA captures (50)

Open the rich text editor's paste chevron menu, then narrow the window until the paste group collapses into More — the menu closes rather than floating past the viewport, the hidden chevron no longer reports aria-expanded, focus lands on More, and widening again restores a working paste chevron

Step Screenshot
Collapsed focus on more Collapsed focus on more
Keyboard collapsed focus on more Keyboard collapsed focus on more
Paste chevron restored wide Paste chevron restored wide
Paste menu open wide Paste menu open wide
1-paste-collapse-and-restore.webm

Tab to a toolbar button in a group about to collapse, then narrow the window — focus moves to More instead of dropping to body; repeat with the caret in the editor content and confirm resizing does not steal focus from the text

Step Screenshot
Bullet list focused 850 Bullet list focused 850
Caret kept after narrow 450 Caret kept after narrow 450
Focus on more after narrow Focus on more after narrow
Format menu collapse 450 Format menu collapse 450

Narrow the editor toolbar step by step and use More at each width — every collapsed action appears (format, script, paste options, insert tools, clear formatting), active formats are highlighted, unavailable ones are disabled, selecting each applies to the editor text, and the chevron rotates while open

Step Screenshot
Active formats highlighted Active formats highlighted
Disabled in code block Disabled in code block
Insert image from more Insert image from more
Math formula from more Math formula from more
More menu open 400 More menu open 400
More menu open 500 More menu open 500
More menu open 660 More menu open 660
More menu open 700 More menu open 700
More menu open 750 More menu open 750
More menu open 800 More menu open 800
More menu open 900 More menu open 900
3-more-chevron-toggle.webm

Operate the More menu by keyboard only — open with Enter/Space, arrow through items, select one, close with Escape, and confirm focus returns to More and the editor still receives the action

Step Screenshot
Math modal from keyboard Math modal from keyboard
More menu keyboard focus More menu keyboard focus
More menu opened by enter More menu opened by enter
Subscript applied via keyboard Subscript applied via keyboard
4-keyboard-more-menu.webm

Widen the window from fully collapsed back to full width with More open and with it closed — More disappears once everything fits, the restored toolbar buttons and paste chevron work normally, and no stale menu stays on screen

Step Screenshot
Collapsed 400 Collapsed 400
Collapsed more open Collapsed more open
Restored paste chevron open Restored paste chevron open
Widened from more open Widened from more open
5-collapse-widen-roundtrip.webm

In a page with two rich text editors (e.g. an exercise question and its answer/hint), collapse one toolbar's paste group while the other's paste menu is open — only the affected editor's menu closes and each More menu acts on its own editor

Step Screenshot
Hint collapsed hint menu closed 760 Hint collapsed hint menu closed 760
Hint collapsed question menu stays 760 Hint collapsed question menu stays 760
Hint more open 620 Hint more open 620
Question collapsed menu closed focus own more 620 Question collapsed menu closed focus own more 620
Question more open hint open 620 Question more open hint open 620
Question paste menu open hint open 850 Question paste menu open hint open 850
Two toolbars open 850 Two toolbars open 850

In the exercise editor, open the Response type select and click elsewhere in the question card, then press Escape on it — the select closes both ways and the chosen type is kept when one is picked

Step Screenshot
Before open Before open
Closed after outside click Closed after outside click
Multiple choice picked Multiple choice picked
Select open Select open
7-select-close-outside-and-escape.webm

Switch the UI to an RTL language and open the toolbar's format dropdown, paste chevron menu and More menu near both window edges — each menu opens aligned to its trigger and stays inside the viewport

Step Screenshot
Rtl 1280 format menu Rtl 1280 format menu
Rtl 1280 paste menu Rtl 1280 paste menu
Rtl 320 format dropdown menu Rtl 320 format dropdown menu
Rtl 320 more button menu Rtl 320 more button menu
Rtl 400 format menu Rtl 400 format menu
Rtl 400 more menu Rtl 400 more menu
Rtl 700 more menu left edge Rtl 700 more menu left edge

Written by rtibblesbot, an LLM-based coding agent.

KListWithOverflow hides the collapsed paste chevron, but its menu is
rendered on body and stayed open past the viewport with the hidden
trigger still aria-expanded. The More button moves into its own
component so it can report the collapsed groups, which KListWithOverflow
only passes to its slot; the toolbar tells PasteDropdown when it has
collapsed, and PasteDropdown closes its menu through KDropdownMenu's
closePopover(), public since KDS 5.10.1.

A collapsing group that held the focus, in a control or in a menu one of
them opened, hands it to More, which now holds those controls. Once every
group fits again, More hands the focus it holds to the first restored
control as it goes. Otherwise the focus would drop to body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@rtibblesbot rtibblesbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6457: all 3 prior findings resolved; 1 new suggestion.

CI passing. Manual QA passed paste collapse, More contents and actions, keyboard focus hand-off, the Response type select, RTL and mobile widths. Axe found only pre-existing violations.

  • suggestion: focus still drops to <body> when More unmounts with its menu open (inline).
Prior-finding status

RESOLVED — PasteDropdown.vue:76 — Focus drops to <body> when an open paste menu closes because its button collapsed
RESOLVED — ToolbarMoreButton.vue — "other component-only actions are skipped" comment was false
RESOLVED — ToolbarMoreButton.vue — Focus drops to <body> when widening removes a More button that has focus
ACKNOWLEDGED — ToolbarMoreButton.vue:24 — Open More menu keeps its old position during a partial widen

Next step: Needs a light-touch code review by a human engineer, then manual QA.

  • User-visible files changed: contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/EditorToolbar.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/PasteDropdown.vue, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/ToolbarMoreButton.vue.
  • Check toolbar collapse and restore at several widths, with keyboard focus on a collapsing group and with the paste and More menus open.
  • Check the Response type select still closes on outside clicks after the KDS 5.10.1 bump.
QA captures (39)

In an exercise question's rich text editor, open the paste chevron menu, then narrow the window until the paste group collapses into More — the paste menu closes with no orphaned menu left on the page, and More then lists both paste options and pasting from there inserts clipboard content

Step Screenshot
Collapsed menu closed focus on more Collapsed menu closed focus on more
More menu lists paste options More menu lists paste options
Paste menu open wide Paste menu open wide
Pasted from more Pasted from more
1-paste-menu-closes-on-collapse.webm

Narrow the rich text editor toolbar step by step until every group has collapsed, then widen it back — More appears and disappears at the right widths, its menu lists exactly the collapsed groups' actions with dividers, icons, disabled and active states, and choosing bold, a list, a script format and an insert tool from it applies to the selection

Step Screenshot
Math formula from more Math formula from more
More menu all collapsed selection More menu all collapsed selection
More menu bold active More menu bold active
Toolbar 320 Toolbar 320
2-narrow-widen-more.webm

Keyboard only: Tab into the rich text toolbar, arrow to a button in a group, then narrow the window so that group collapses — focus lands on More, not body; open More with Enter and pick an item; then widen until More vanishes while focused — focus moves to the first restored group's button and arrow keys keep navigating the toolbar

Step Screenshot
Focus on more after collapse Focus on more after collapse
Focus on restored bullet list Focus on restored bullet list
More menu open keyboard More menu open keyboard
3-keyboard-focus-collapse-restore.webm

Open the text format dropdown and the paste menu in turn, close each with Escape while narrowing the window so their group has collapsed, and confirm focus goes to More rather than being lost; repeat with More's own menu open while widening until More disappears and confirm its menu closes

Step Screenshot
Format menu open 500 Format menu open 500
More menu open 900 More menu open 900

In the exercise editor, open the "Response type" select on a question, click elsewhere in the question card, then reopen it and pick a different type — the select closes on the outside click and the chosen type applies (KDS 5.10.1)

Step Screenshot
Multiple choice applied Multiple choice applied
Select closed after outside click Select closed after outside click
Select open Select open
Single choice restored Single choice restored
5-select-closes-on-stop-propagation-click.webm
5-select-outside-click-reopen-pick.webm

With Studio's language set to an RTL language (e.g. Arabic), open the rich text toolbar's More menu, the paste menu and the text format dropdown near the window's edges and at narrow widths — each menu opens aligned to its button, flipped for RTL, and stays within the viewport

Step Screenshot
Rtl format menu 1400 Rtl format menu 1400
Rtl format menu 360 Rtl format menu 360
Rtl more menu 360 Rtl more menu 360
Rtl more menu 400 Rtl more menu 400
Rtl more menu 500 Rtl more menu 500
Rtl more menu 640 Rtl more menu 640
Rtl more menu 640x450 scrolled Rtl more menu 640x450 scrolled
Rtl more menu 900 Rtl more menu 900
Rtl paste menu 1400 Rtl paste menu 1400

At a small (mobile) window width, edit an exercise answer and a hint in the rich text editor — the toolbar shows its compact layout, More holds the collapsed actions, its menu fits the screen, and selecting from it formats the text

Step Screenshot
Answer formatted Answer formatted
Answer more menu 390 Answer more menu 390
Answer toolbar 390 Answer toolbar 390
Hint formatted Hint formatted
Hint math from more 320 Hint math from more 320
Hint more menu 320x568 Hint more menu 320x568
Hint more menu 390 Hint more menu 390
7-hint-more-format-390.webm

Written by rtibblesbot, an LLM-based coding agent.

});

onBeforeUnmount(() => {
if (hasFocus) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Focus drops to <body> when More unmounts with its menu open.

  • The menu options render outside the button, in body.
  • Focusing an option fires the button's focusout, which clears hasFocus.
  • So release-focus is never emitted.
  • Steps: Q1 editor at 900px → open More (focus on "Subscript") → widen to 1000px → document.activeElement is BODY.
  • Count an open menu as holding focus, as EditorToolbar.vue already does with aria-expanded="true".
  • Add a case to the "hands the focus from More to the first restored control" test that opens the menu first.
4-more-menu-widen-focus-lost.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QTI] - 'Response type' drop-down issues

2 participants