Repository navigation
Run development, tests and CI against fake-gcs-server instead of minio - #6450
Open
rtibblesbot wants to merge 2 commits into
Open
rtibblesbot wants to merge 2 commits into
rtibblesbot wants to merge 2 commits into
Conversation
rtibblesbot
marked this pull request as ready for review
November 18, 2026 07:22
rtibblesbot
force-pushed
the
issue-6445-a618cd
branch
from
November 18, 2026 07:29
3136141 to
114e873
Compare
- fake-gcs-server replaces minio in compose, the Makefile and CI - Dev and test default STORAGE_EMULATOR_HOST; STUDIO_GCS_EMULATOR=0 opts dev out to a real bucket - CompositeGCS builds clients lazily, so migrate needs no credentials - Emulated presigned uploads return a resumable session URL - upload_url passes a dotted extension to generate_object_storage_name - generate_storage_url always returns /content/<path>; dev file_server redirects to the emulator or the real bucket - Drop django-s3-storage and RUN_MODE Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6445-a618cd
branch
from
November 19, 2026 07:58
114e873 to
ee19320
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fake-gcs-serverreplaces minio and S3 storage;STUDIO_GCS_EMULATOR=0uses a real bucket.References
Fixes #6445. Replaces #5990.
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
Engineer review
.github/workflows/pythontest.yml.pnpm services,make dcservicesup,make dcupand CI startfake-gcs-serverand no minio. (needs a container runtime)upload_urlwithresumable: truereturns a session URI from the emulator, and a file uploaded to it is stored. (needs a running fake-gcs-server; the agent reaches one only through CI's Python job)test_storage_common.pyandtest_gcs_storage.py. (needs a running fake-gcs-server; the agent reaches one only through CI's Python job)Engineer evidence
Skipped here, so verify it: Setting an environment variable makes local development use a real GCS bucket. (needs a GCS bucket and Google credentials)
dev_urls.pykeeps the/content/redirect, retargeted at the emulator; the issue asks to remove it.sandbox_settings.pystays on real GCS; the issue covers every non-production environment.Browser uploads under
make dcupstay broken, since session URIs namegcs:4443.docker-compose.prod.ymlpreviews 404, sincecontentcuration.urlshas no/content/route; the maintainer said to leave it.Confirm production should store zero-byte uploads instead of skipping them (
contentcuration/contentcuration/utils/gcs_storage.py:143).Confirm uploads whose name has no extension should be stored at
<checksum>.<format>, not<checksum><format>(contentcuration/contentcuration/viewsets/file.py:256).Confirm production sets
AWS_S3_ENDPOINT_URL, or thatget_file_diffmay default tohttps://storage.googleapis.com(contentcuration/contentcuration/settings.py:365-369).Unverified (no containers in sandbox): CI,
make dcservicesup,make dcup,pnpm services,STUDIO_GCS_EMULATOR=0.Questions:
savestores zero-byte files — OK?<checksum>.<format>— OK?AWS_S3_ENDPOINT_URL?Risks:
make dcupbrowser uploads fail, as with minio.docker-compose.prod.ymlpreviews 404.QA review
make dcservicesup+pnpm devserver: a file uploaded in the channel editor lands in the emulator'scontentbucket and previews.make dcupfrom a fresh checkout finishessetup, and existing files preview atlocalhost:8080andlocalhost:8081.pnpm servicesstarts the hostfake-gcs-serverbinary installed perdocs/local_dev_host.md:37-52.STUDIO_GCS_EMULATOR=0with a real bucket uploads and previews (docs/local_dev_host.md:155-179).Python unit testsjob starts the emulator throughdocker composeand passes (.github/workflows/pythontest.yml:67-70).AI usage
Claude Code wrote and tested this.
Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
WAITING · on a reviewerLast updated: 2026-11-19 08:03 UTC