Skip to content

ci: queue agent-leftovers runs instead of cancelling in-progress runs - #28

Open
dkhawk wants to merge 1 commit into
mainfrom
ci/agent-leftovers-no-cancel
Open

dkhawk wants to merge 1 commit into
mainfrom
ci/agent-leftovers-no-cancel

Conversation

@dkhawk

@dkhawk dkhawk commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Sets cancel-in-progress: false in .github/workflows/agent-leftovers.yml so back-to-back pull_request events queue sequentially instead of cancelling each other.

Why

  • agent-leftovers.yml triggers on types: [opened, synchronize, reopened, edited] and runs in ~4 seconds.
  • When automation like release-please updates a release PR (e.g., #19), it emits synchronize (push) and edited (title/body update) within a second on the same head SHA.
  • With cancel-in-progress: true, the second event cancels the first run and leaves a stale cancelled check attached to the PR even though the sibling run passes.
  • Setting cancel-in-progress: false preserves sequential ordering (so an older run cannot finish after a newer title/body fix) while letting both runs succeed cleanly.

Verification

  • Audited all workflows under .github/workflows/; agent-leftovers.yml is the only workflow combining edited triggers with cancel-in-progress: true.
  • Validated YAML syntax with yaml.safe_load.

Sets cancel-in-progress to false in .github/workflows/agent-leftovers.yml so rapid synchronize and edited webhook events (such as release-please PR updates) run sequentially instead of leaving a stale cancelled check on the PR.
@dkhawk
dkhawk requested review from a team and kikoso as code owners November 19, 2026 19:04
@github-actions

Copy link
Copy Markdown

Coverage (unit tests)

No unit baseline recorded in coverage/history.csv yet, so this run only reports absolute numbers.

Module Line % Change Branch % Change
golden-testing 90.42% new 58.00% new
robolectric-testing 84.25% new 51.87% new
visual-testing 63.58% new 35.16% new
TOTAL 82.28% new 47.11% new

Line and branch coverage from unit test reports. History is recorded in coverage/history.csv after each merge to main.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant