Repository navigation
Conversation
…ent-leftovers Adds DIFF_ONLY_PATTERNS to check_agent_leftovers.py to catch unauthorized JavaVersion/JvmTarget bumps past 17, jvmToolchain additions, foojay-resolver references, local org.gradle.java.home overrides, and CI java-version bumps past 21 on added diff lines, and adds gradle-daemon-jvm.properties to FILE_PATTERNS.
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
.github/scripts/check_agent_leftovers.pyto catch accidental JDK and Gradle toolchain changes introduced from workstation environments with bleeding-edge default JDKs:DIFF_ONLY_PATTERNS(checked on added diff lines viascan_text(text, include_diff_only=True), leaving commit messages and PR titles/bodies free to reference these terms):JavaVersion.VERSION_*> 17JvmTarget.JVM_*> 17jvmToolchain(...)additionsfoojay-resolverreferencesorg.gradle.java.homeoverridesjava-version:> 21gradle-daemon-jvm.propertiestoFILE_PATTERNS.Lines that legitimately require one of these settings can opt out with
agent-leftovers: ignore.Verification
DIFF_ONLY_PATTERNSandgradle-daemon-jvm.propertiestrigger cleanly (exit 1) on added diff lines/files in an end-to-end test repository.JavaVersion.VERSION_1_8/11/17,JvmTarget.JVM_1_8/11/17,java-version: '17'/'21'),agent-leftovers: ignoreopt-outs, commit/PR metadata discussing these tokens, and edits toSKIPPED_FILESall pass (exit 0).