Skip to content

test(bigquery-storage): [C09] unskip and update large AppendRows test - #9902

Draft
feywind wants to merge 1 commit into
c09/bigquery-unskip-date-testsfrom
c09/bigquery-storage-large-request-test
Draft

feywind wants to merge 1 commit into
c09/bigquery-unskip-date-testsfrom
c09/bigquery-storage-large-request-test

Conversation

@feywind

@feywind feywind commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

Unskips and updates the large AppendRows request system test.

Impact

Restores system test coverage for oversized AppendRows errors and reconnection.

Changes

  • Unskip send large request should return an error in handwritten/bigquery-storage/system-test/managed_writer_client_test.ts.
  • Increase the oversized request payload from 11 MiB to 21 MiB to exceed the BigQuery Storage Write API 20 MiB AppendRowsRequest limit, using a larger customer_name string to avoid allocating ~1.8M tiny row buffers.
  • Register connection.onConnectionError(...) and assert that the oversized AppendRows call rejects with gax.Status.INVALID_ARGUMENT while a subsequent valid write reconnects and succeeds at offset 0.

Testing

  • Compiled handwritten/bigquery-storage (pnpm run compile).
  • Ran send large request should return an error against the live BigQuery Storage Write API 3 consecutive times: all 3 passed (~2.4s-2.9s each).
  • Ran pnpm --dir handwritten/bigquery-storage test: 14 passing, 0 failing.
  • Ran package ESLint (eslint --no-ignore system-test/managed_writer_client_test.ts): 0 errors and 0 warnings on touched lines.

Alternatives

  • Leaving the test skipped or deleting it leaves oversized AppendRows error handling and post-error stream reconnection untested against the live service.

@product-auto-label product-auto-label Bot added the api: bigquerystorage Issues related to the BigQuery Storage API. label Nov 18, 2026
@feywind
feywind added this pull request to stack #9907 November 18, 2026 22:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables and updates the system test for sending large requests in the BigQuery Storage Managed Writer client. Specifically, it increases the target payload size to 21 MiB to exceed the 20 MiB API limit, tracks connection errors using an event listener, and refactors the assertions to use assert.rejects to verify that the request fails with an INVALID_ARGUMENT status. There are no review comments, and I have no additional feedback to provide.

@feywind

feywind commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

This is just preliminary test-run work on this one.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the BigQuery Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant