Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables and updates the system test for sending large requests in the BigQuery Storage Managed Writer client. Specifically, it increases the target payload size to 21 MiB to exceed the 20 MiB API limit, tracks connection errors using an event listener, and refactors the assertions to use assert.rejects to verify that the request fails with an INVALID_ARGUMENT status. There are no review comments, and I have no additional feedback to provide.
Contributor
Author
|
This is just preliminary test-run work on this one. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unskips and updates the large AppendRows request system test.
Impact
Restores system test coverage for oversized AppendRows errors and reconnection.
Changes
send large request should return an errorinhandwritten/bigquery-storage/system-test/managed_writer_client_test.ts.AppendRowsRequestlimit, using a largercustomer_namestring to avoid allocating ~1.8M tiny row buffers.connection.onConnectionError(...)and assert that the oversizedAppendRowscall rejects withgax.Status.INVALID_ARGUMENTwhile a subsequent valid write reconnects and succeeds at offset0.Testing
handwritten/bigquery-storage(pnpm run compile).send large request should return an erroragainst the live BigQuery Storage Write API 3 consecutive times: all 3 passed (~2.4s-2.9s each).pnpm --dir handwritten/bigquery-storage test: 14 passing, 0 failing.eslint --no-ignore system-test/managed_writer_client_test.ts): 0 errors and 0 warnings on touched lines.Alternatives
AppendRowserror handling and post-error stream reconnection untested against the live service.