Skip to content

chore: [C09] remove broken sample scripts from bigquery and pubsub - #9898

Draft
feywind wants to merge 1 commit into
c09/storage-conformance-path-exclusionsfrom
c09/remove-broken-sample-scripts
Draft

feywind wants to merge 1 commit into
c09/storage-conformance-path-exclusionsfrom
c09/remove-broken-sample-scripts

Conversation

@feywind

@feywind feywind commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes broken samples-test, link-samples, and prelint scripts from three packages.

Impact

Prevents lint and script failures caused by nonexistent samples directories.

Changes

  • Remove broken samples-test and prelint scripts from handwritten/bigquery/package.json.
  • Remove broken samples-test and prelint scripts from handwritten/bigquery-storage/package.json.
  • Remove broken samples-test, link-samples, and prelint scripts from handwritten/pubsub/package.json.

Testing

  • Validated JSON syntax for all three modified package.json files and confirmed the remaining scripts (lint, test, system-test, compile, docs) are preserved.

Alternatives

  • Leaving these scripts in place breaks pnpm run lint (via prelint attempting cd samples) and exposes non-functional samples-test targets.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Nov 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the samples-test, prelint, and sample-linking scripts from the package.json files of the bigquery-storage, bigquery, and pubsub packages. I have no feedback to provide as there are no review comments and the changes are straightforward cleanup of scripts.

@feywind
feywind added this pull request to stack #9907 November 18, 2026 22:47
@feywind

feywind commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

This is just preliminary test-run work on this one.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant