Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the samples-test, prelint, and sample-linking scripts from the package.json files of the bigquery-storage, bigquery, and pubsub packages. I have no feedback to provide as there are no review comments and the changes are straightforward cleanup of scripts.
Contributor
Author
|
This is just preliminary test-run work on this one. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes broken samples-test, link-samples, and prelint scripts from three packages.
Impact
Prevents lint and script failures caused by nonexistent samples directories.
Changes
samples-testandprelintscripts fromhandwritten/bigquery/package.json.samples-testandprelintscripts fromhandwritten/bigquery-storage/package.json.samples-test,link-samples, andprelintscripts fromhandwritten/pubsub/package.json.Testing
package.jsonfiles and confirmed the remaining scripts (lint,test,system-test,compile,docs) are preserved.Alternatives
pnpm run lint(viaprelintattemptingcd samples) and exposes non-functionalsamples-testtargets.