Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates .github/CODEOWNERS to include the /handwritten/pubsub path, changes the library type of bigquery-storage to GAPIC_COMBO, and updates the codeowner team for bigquery to @googleapis/bigquery-team. The reviewer pointed out that /handwritten/bigquery is missing from .github/CODEOWNERS and should be added to ensure proper ownership mapping.
| "api_id": "bigquery.googleapis.com", | ||
| "requires_billing": false, | ||
| "codeowner_team": "@googleapis/api-bigquery", | ||
| "codeowner_team": "@googleapis/bigquery-team", |
There was a problem hiding this comment.
The repository metadata for bigquery is being updated to use @googleapis/bigquery-team, but /handwritten/bigquery does not appear to be listed in .github/CODEOWNERS (only /handwritten/bigquery-storage is present). Please add /handwritten/bigquery to .github/CODEOWNERS to ensure ownership is correctly mapped.
|
This is just preliminary test-run work on this one. |
Description
Updates CODEOWNERS and package metadata for pubsub, bigquery, and bigquery-storage.
Impact
Ensures accurate code review routing and library metadata classification.
Changes
/handwritten/pubsubwith@googleapis/cloud-sdk-nodejs-teamand@googleapis/pubsub-teamto.github/CODEOWNERS.codeowner_teaminhandwritten/bigquery/.repo-metadata.jsonfrom@googleapis/api-bigqueryto@googleapis/bigquery-teamto match.github/CODEOWNERS.library_typeinhandwritten/bigquery-storage/.repo-metadata.jsonfromGAPIC_AUTOtoGAPIC_COMBOto reflect that the package is a handwritten veneer wrapping@google-cloud/bigquery-storage-api.Testing
.repo-metadata.jsonfiles..github/CODEOWNERSformatting and team names match existing entries andhandwritten/pubsub/.repo-metadata.json.Alternatives
.github/CODEOWNERSand.repo-metadata.jsonmisaligned causes Pub/Sub pull requests to miss partner-team review notifications and misclassifies BigQuery Storage in repository tooling.