Repository navigation
Conversation
- Subsets Material Symbols Outlined and Rounded icon fonts with display=block, 1em icon boxes, www.gstatic.com preconnect, and two-way workspace ligature drift tests, scoping blog-only fonts to BlogLayout. - Converts marketing slide keyframes from top to transform: translate3d, drops banner text-wrap: balance, and replaces nested <a> tags in homepage news cards with .read-more spans.
There was a problem hiding this comment.
Code Review
This pull request optimizes font and icon loading across the workspace by introducing a reusable @mixin material-symbol in SASS, transitioning from top positioning to hardware-accelerated transform: translate3d animations, and subsetting both Material Symbols Outlined and Material Symbols Rounded fonts using the icon_names query parameter. It also adds robust synchronization tests to ensure the configured icon subsets stay in sync with actual code usages. The review feedback recommends filtering out common non-icon tokens (such as 'none', 'default', and 'blog') in the new material_symbols_subset_test.dart regex extractors to prevent fragile test failures.
|
Staged preview of the updated docs.flutter.dev site (updated for commit a13f1ea): https://flutter-docs-prod--docs-pr14107-gsc-font-css-cls-bx5ma142.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit a13f1ea): https://flutter-dev-230821--www-pr14107-gsc-font-css-cls-ece2k13u.web.app |
…et lints - Style `.carousel-card > a` as a full-height flex column with `margin-top: auto` on `.read-more` so card titles and CTAs stay bottom-aligned and paint above `.carousel-card-bg` on hover after removing the nested `<a>`. - Replace `top: 0` with `transform: none` on `.features .stacked-feature .feature` to match the composited `translate3d` `.feature` offset. - Wrap subsetted Google Fonts `icon_names` literals within 80 columns so `dart analyze --fatal-infos` passes cleanly across `site_shared` and `www`. - Scope HTML element tag filtering (`aside`, `div`, `span`) strictly to `_enumOrSwitchReturnPattern` and extract ternary icon branches so valid Material Symbols ligatures (`toc`, `note`, `light`) are not masked in subset sync tests.
Eliminates font, icon, banner, and slide-animation layout shifts across
docs.flutter.devandflutter.devwhile cutting marketing font payload by98%.Material Symbols Outlined(
121workspace ligatures) andMaterial Symbols Rounded(25flutter.devligatures) with
display=block,1emicon box clipping(
box-sizing: content-box), andhttps://www.gstatic.compreconnect; movesRoboto SerifandMaterial Symbols OutlinedtoBlogLayout(flutter.devnon-blog font payload drops from
~1,040 KBto~21 KB), guarded by two-wayworkspace ligature drift tests.
flutter.devtopslidekeyframes to GPU-composited
transform: translate3d(...), dropstext-wrap: balanceon the site banner, and replaces nested<a>tags insidehomepage news cards with
.read-morespans.Presubmit checklist
of 80 characters or fewer.