Repository navigation
Conversation
ppamorim
marked this pull request as ready for review
November 19, 2026 03:54
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a customizable scrimColor property to OpenContainer to allow customization of the scrim color during route transitions, updating the package version to 3.1.0 and adding corresponding tests. The review feedback notes that the use of withValues and Color.a requires updating the minimum Flutter SDK constraint in pubspec.yaml to >=3.24.0 to avoid compilation errors, and suggests using 0.0 instead of 0 for the alpha parameter for type consistency.
ppamorim
force-pushed
the
animations-scrim-color
branch
from
November 19, 2026 03:58
23f77d7 to
eeae0af
Compare
ppamorim
force-pushed
the
animations-scrim-color
branch
from
November 20, 2026 00:28
eeae0af to
a8bed7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
scrimColorparameter toOpenContainer. The scrim drawn over the underlying main view during the container transform was hard-coded toColors.black54, apps couldn't match it to their theme (e.g. a lighter scrim, a tinted scrim, or none at all). This PR adds minimum flexibility for now, a more complete version can be implemented in the future if the team believes it's the best path to follow.The existing behaviour is unchanged. The fade-in/fade-out tweens are now built per route from this colour with the same weights and curves as before, for both
ContainerTransitionType.fadeandContainerTransitionType.fadeThrough.The scrim fades from a fully transparent
scrimColor(rather than transparent black, because the gradient would be broken), so only the alpha animates and lighter or tinted scrims don't darken mid-fade. For the defaultColors.black54this is identical to the previous behaviour. PassingColors.transparentdisables the scrim.Fixes flutter/flutter#59949
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2