Skip to content

[in_app_purchase] Link to platform purchase testing guides - #13711

Open
Wreos wants to merge 5 commits into
flutter:mainfrom
Wreos:docs/in-app-purchase-test-guides
Open

Wreos wants to merge 5 commits into
flutter:mainfrom
Wreos:docs/in-app-purchase-test-guides

Conversation

@Wreos

@Wreos Wreos commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Adds a testing section to the in_app_purchase README so developers can find Apple’s StoreKit Testing setup and Google’s Play Billing license tester instructions during development.

Fixes flutter/flutter#163330.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: in_app_purchase P3 Issues that are less important to the Flutter project labels Nov 18, 2026
@Wreos

Wreos commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

This PR only adds testing links to the README. I included a patch version bump and a changelog entry. Should I keep both for this documentation change, or would you prefer to leave the version at 3.3.1 and include the entry in the next release?

@Wreos
Wreos marked this pull request as ready for review November 18, 2026 17:53
@github-actions
github-actions Bot marked this pull request as draft November 18, 2026 17:53
@github-actions github-actions Bot added the waiting for response The Flutter team cannot make further progress on this PR until the author responds label Nov 18, 2026
@github-actions

Copy link
Copy Markdown

Hi @Wreos, thank you for your contribution!

This pull request has been converted to a draft because it does not appear to follow our pull request template:

  • Unchecked checklist items (11 of 11): All items in the Pre-Review Checklist must be completed and checked off (- [x]) before the PR can be reviewed:
    • - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
    • - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
    • - [ ] I read the [Tree Hygiene] page, which explains my responsibilities.
    • - [ ] I read and followed the [relevant style guides] and ran [the auto-formatter].
    • - [ ] I signed the [CLA].
    • - [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]`
    • - [ ] I [linked to at least one issue that this PR fixes] in the description above.
    • - [ ] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
    • - [ ] I updated/added any relevant documentation (doc comments with `///`).
    • - [ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
    • - [ ] All existing and new tests are passing.

How to fix this

  1. Click the ... menu in the top-right corner of your PR description above and select Edit.
  2. Address the issues listed above. Make sure every item in the Pre-Review Checklist is present without modifications and checked off (- [x]).
  3. Save your changes, then click the "Ready for review" button at the bottom of the PR.
Click here for the raw Markdown of the Pre-Review Checklist to copy and paste
## Pre-Review Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] page, which explains my responsibilities.
- [ ] I read and followed the [relevant style guides] and ran [the auto-formatter].
- [ ] I signed the [CLA].
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]`
- [ ] I [linked to at least one issue that this PR fixes] in the description above.
- [ ] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
- [ ] I updated/added any relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

<!-- Links -->
[Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[AI contribution guidelines]: https://github.com/flutter/flutter/blob/master/CONTRIBUTING.ai.md#pull-requests
[Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
[CLA]: https://cla.developers.google.com/
[Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates
[semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions
[repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

@Wreos
Wreos marked this pull request as ready for review November 18, 2026 17:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the in_app_purchase package version to 3.3.2 and adds documentation to the README regarding testing in-app purchases on iOS, macOS, and Android. A review comment was provided suggesting a minor textual improvement for clarity in the Android testing section.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the in_app_purchase package to version 3.3.2 and adds a 'Testing in-app purchases' section to the README, providing links to official testing guides for iOS, macOS, and Android. The review feedback suggests a phrasing improvement in the Android testing section to clarify that 'it' refers to the Google account.

@github-actions github-actions Bot removed the waiting for response The Flutter team cannot make further progress on this PR until the author responds label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: in_app_purchase P3 Issues that are less important to the Flutter project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase] Add README links to authoritative docs about test setup

1 participant