Repository navigation
xen/balloon: let the OOM notifier grow an empty domU balloon - #84
Merged
Merged
Conversation
Since a6aa4eb ("xen/x86: add extra pages to unpopulated-alloc if available"), a domU built below its maximum hands the rest of its physmap to the unpopulated allocator at boot, so its balloon stays empty until the toolstack first resizes it. balloon_oom_notify() only deflates pages already on the balloon, so a freshly built domU kills a task instead of growing toward its maximum. When the balloon is empty, park one 2 MiB block from the unpopulated allocator on it and deflate that, as dom0's balloon does when it grows. The allocator allocates memory with its lock held, so the OOM path only tries the lock, through a new xen_try_alloc_unpopulated_blocks(). Signed-off-by: Kavi <kavi@edera.dev>
kdaula
marked this pull request as ready for review
November 4, 2026 01:51
azenla
approved these changes
Nov 4, 2026
3 tasks done
|
wasn't this scenario fixed before? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zone built below its maximum memory gets OOM-killed instead of growing toward its maximum. Since upstream a6aa4eb a domU hands the unpopulated part of its physmap to the unpopulated allocator at boot, so its balloon stays empty until the toolstack first resizes it, and the OOM notifier only deflates pages already on the balloon.
When the balloon is empty, the notifier now parks one 2 MiB block from the unpopulated allocator on it and deflates that, as dom0's balloon does when it grows. The allocator allocates memory with its lock held, so the OOM path only try-locks it, through a new xen_try_alloc_unpopulated_blocks().
Tested on a 256 MiB domU with its Xen ceiling at a 1 GiB maximum: with this change it grows 2 MiB per OOM event and a 640 MiB allocation completes; without it the allocation is killed and the domU stays at 256 MiB.
COR-198