Repository navigation
x86/xen: clear the user pgd pointer when freeing it - #78
Merged
Merged
Conversation
xen_pgd_alloc() keeps the user pgd of a 64-bit PV mm in page->private of the kernel pgd page, and xen_pgd_free() frees it without clearing the pointer. page->private shares its slot with ptdesc->ptl, so when split ptlocks are allocated separately (lock debugging, PREEMPT_RT), pagetable_dtor() hands the freed user pgd to kmem_cache_free() as a ptlock. With SLUB consistency checks this warns "virt_to_cache: Object is not a Slab page!" on every mm teardown; without them it corrupts the slab. Clear page->private once the user pgd is freed. Signed-off-by: Kavi <kavi@edera.dev>
kdaula
marked this pull request as ready for review
November 3, 2026 23:58
kaniini
approved these changes
Nov 4, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Xen PV kernel with lock debugging, every mm teardown warns "virt_to_cache: Object is not a Slab page!" from ptlock_free() in pgd_free(), in dom0 and in every PV domU at boot.
xen_pgd_alloc() keeps the user pgd in page->private of the kernel pgd page, and that field shares its slot with ptdesc->ptl. xen_pgd_free() frees the user pgd but leaves the pointer, so when split ptlocks are allocated separately (lock debugging, PREEMPT_RT) pagetable_dtor() frees it again as a ptlock. Without SLUB consistency checks that corrupts the slab. Shipped kernels never allocate split ptlocks separately, so they are unaffected. Upstream master has the same code.
This clears page->private after freeing the user pgd.
Tested by booting a lock-debugging dom0 and PV domU under Xen with this applied: the warning no longer appears.
COR-190