Repository navigation
Conversation
etimberg
previously approved these changes
Nov 16, 2026
Contributor
Author
|
I've just openned a pr to fixe the type import on |
Ph0tonic
force-pushed
the
chore/update-kurkle-color
branch
from
November 19, 2026 16:29
0a63e99 to
5b2cfb7
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ph0tonic
force-pushed
the
chore/update-kurkle-color
branch
from
November 19, 2026 16:33
5b2cfb7 to
479662b
Compare
etimberg
approved these changes
Nov 19, 2026
Member
Will re-run the CI tomorrow and this shoudl pass and we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for CSS Color Level 4
oklch()colors by updating@kurkle/colorfrom^0.3.0to^0.6.6.Fixes #12101
What changes for users
With 0.3.x, an
oklch()color draws fine on the canvas, but@kurkle/colorcan't parse it:hoverBackgroundColor,hoverBorderColor,hoverColor) are computed from an invalid color.0.6.6 parses
oklch(). It also accepts/as the alpha separator inhsl()/hwb(), accepts scientific notation inrgb(), and roundsrgb()percentages and fractional channels the way browsers do.Why 0.6.6 and not an earlier 0.5.x/0.6.x release
From 0.5.0 to 0.6.5,
@kurkle/colorbroke two things Chart.js relies on:require('@kurkle/color')only returned{ default }, so Chart.js's CommonJS build threwcolor$1.Color is not a constructorfromcolor()andgetHoverColor().moduleResolution: "node":import { Color } from '@kurkle/color'in our declarations failed with TS2614. This is what made thetypescript-nodeintegration test fail on the first version of this PR.Both are fixed upstream in 0.6.6 (kurkle/color@0cb8e9b), which also adds regression tests against Chart.js's CommonJS build and node10 types.
Changes
package.json/pnpm-lock.yaml:@kurkle/color^0.6.6test/specs/helpers.color.tests.js,test/specs/core.animation.tests.js:oklch()parsing, hover color and animation (they fail on 0.3.2)test/integration/node-commonjs,test/integration/node: callcolor()andgetHoverColor(), which would have caught the CommonJS crashmaster(pnpm 12, Node 26, Rollup 4)Testing
Locally, in Docker with Node 26 and pnpm 12.21.0, following the CI steps:
pnpm run lint, Karma on Chrome and Firefox (3412/3412), and all integration tests.Note: pnpm 12's
minimumReleaseAgerejects 0.6.6 for 24 hours after it was published, so the rebased commit will be pushed once it is old enough. No exception was added topnpm-workspace.yaml.🤖 Generated with Claude Code