Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 21 additions & 27 deletions src/main/java/com/thealgorithms/maths/PronicNumber.java
Original file line number Diff line number Diff line change
@@ -1,51 +1,45 @@
package com.thealgorithms.maths;

/*
* Java program for Pronic Number
* Pronic Number: A number n is a pronic number if
* it is equal to product of two consecutive numbers m and m+1.
/**
* Pronic Number: A number n is a pronic number (or oblong number) if
* it is equal to the product of two consecutive integers m and m + 1 (for m >= 0).
* Wikipedia: https://en.wikipedia.org/wiki/Pronic_number
*
* Author: Akshay Dubey (https://github.com/itsAkshayDubey)
*
* */

* @author Akshay Dubey (https://github.com/itsAkshayDubey)
*/
public final class PronicNumber {
private PronicNumber() {
}

/**
* This method checks if the given number is pronic number or non-pronic number
* Checks if the given number is a pronic number iteratively.
*
* @param inputNumber Integer value which is to be checked if is a pronic number or not
* @return true if input number is a pronic number, false otherwise
* @param inputNumber integer value to be checked
* @return true if inputNumber is a pronic number, false otherwise
*/
static boolean isPronic(int inputNumber) {
if (inputNumber == 0) {
return true;
public static boolean isPronic(int inputNumber) {
if (inputNumber < 0) {
return false;
}
// Iterating from 0 to input_number
for (int i = 0; i <= inputNumber; i++) {
// Checking if product of i and (i+1) is equals input_number
if (i * (i + 1) == inputNumber && i != inputNumber) {
// return true if product of i and (i+1) is equals input_number
for (int i = 0; (long) i * (i + 1) <= inputNumber; i++) {
if ((long) i * (i + 1) == inputNumber) {
return true;
}
}

// return false if product of i and (i+1) for all values from 0 to input_number is not
// equals input_number
return false;
}

/**
* This method checks if the given number is pronic number or non-pronic number using square root of number for finding divisors
* Checks if the given number is a pronic number in O(1) time using square root.
*
* @param number Integer value which is to be checked if is a pronic number or not
* @return true if input number is a pronic number, false otherwise
* @param number integer value to be checked
* @return true if number is a pronic number, false otherwise
*/
public static boolean isPronicNumber(int number) {
int squareRoot = (int) Math.sqrt(number); // finding just smaller divisor of the number than its square root.
return squareRoot * (squareRoot + 1) == number;
if (number < 0) {
return false;
}
int squareRoot = (int) Math.sqrt(number);
return (long) squareRoot * (squareRoot + 1) == number;
}
}
4 changes: 2 additions & 2 deletions src/test/java/com/thealgorithms/maths/PronicNumberTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
public class PronicNumberTest {

@ParameterizedTest
@ValueSource(ints = {0, 2, 6, 12, 20, 30, 42, 110, 272, 380, 420, 1260, 2550})
@ValueSource(ints = {0, 2, 6, 12, 20, 30, 42, 110, 272, 380, 420, 1260, 2550, 2147441940})
void testForPronicNumber(final int number) {
Assertions.assertTrue(PronicNumber.isPronic(number));
Assertions.assertTrue(PronicNumber.isPronicNumber(number));
}

@ParameterizedTest
@ValueSource(ints = {1, 4, 21, 36, 150, 2500})
@ValueSource(ints = {-10, -2, -1, 1, 4, 21, 36, 150, 2500, 2147483647})
void testForNonPronicNumber(final int number) {
Assertions.assertFalse(PronicNumber.isPronic(number));
Assertions.assertFalse(PronicNumber.isPronicNumber(number));
Expand Down
Loading