Repository navigation
fix(typescript): fix sourcemap sourcecontent referencing non-existent files - #1571
Merged
shellscape merged 3 commits intoSep 25, 2023
Conversation
Contributor
Author
|
It seems that pnpm 8 has dropped support for Node.js 14. The CI pipeline will need to be updated after 0278630. |
3 of 9 tasks
Collaborator
|
@ianyong please update your branch from upstream so we can run the latest CI |
shellscape
pushed a commit
that referenced
this pull request
Sep 25, 2023
… files (#1571) * test(typescript): add test case for incorrect `sourceContent` * fix(typescript): fix .js.map files being treated as declarations
shellscape
pushed a commit
that referenced
this pull request
Sep 25, 2023
* fix(typescript): fix sourcemap sourcecontent referencing non-existent files (#1571) * test(typescript): add test case for incorrect `sourceContent` * fix(typescript): fix .js.map files being treated as declarations * fix(dsv): type of processRow * test(dsv): update test for processRow types --------- Co-authored-by: Ian Yong <ianyongyc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
In #1555, I changed:
plugins/packages/typescript/src/outputFile.ts
Lines 23 to 28 in 303ff16
to:
plugins/packages/typescript/src/outputFile.ts
Lines 23 to 28 in 0278630
It turns out that this was a mistake (oops!) because
isMapOutputFileis also used in theloadbuild hook to determine the map file for every code file. With the change made above,.js.mapfiles were incorrectly being treated as declaration files instead of map files.To resolve this issue, I have split the predicate functions:
isMapOutputFileis used to determine if a file is a map file for use in theloadbuild hook whileisTypeScriptMapOutputFileis used to determine if a file is a TypeScript map file for emitting.