Skip to content

fix(typescript): change the value of isExternalLibraryImport to false if the resolvedModule should be compiled - #1521

Merged
tada5hi merged 1 commit into
rollup:masterfrom
TrickyPi:fix/1520
Jun 28, 2023
Merged

tada5hi merged 1 commit into
rollup:masterfrom
TrickyPi:fix/1520

Conversation

@TrickyPi

Copy link
Copy Markdown
Member

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #1520

Description

If the module's path contains 'node_modules', ts considers it an external library and refuses to compile it,
so we have to change the value of isExternalLibraryImport to false if it's true

@TrickyPi
TrickyPi requested a review from shellscape as a code owner June 15, 2023 07:41
@TrickyPi

Copy link
Copy Markdown
Member Author

Could this PR be merged now? It already has two approvals.

@tada5hi
tada5hi merged commit 6b134ed into rollup:master Jun 28, 2023
@TrickyPi
TrickyPi deleted the fix/1520 branch June 28, 2023 13:51
@taylorfsteele

taylorfsteele commented Jul 5, 2023 •

Copy link
Copy Markdown

Perfectly fixed my issue when using the filterRoot option. Thanks @TrickyPi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-typescript] Doesn't parse packages outside root dir, monorepo packages

4 participants