Skip to content

fix(typescript): Allow for using compilerOptions.moduleResolution - #1453

Merged
shellscape merged 2 commits into
rollup:masterfrom
susnux:fix/typescript-moduleresolution
May 12, 2023
Merged

shellscape merged 2 commits into
rollup:masterfrom
susnux:fix/typescript-moduleresolution

Conversation

@susnux

@susnux susnux commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Align module resolution with the typescript compiler:
If moduleResolution is set it should be used and only if it is omitted the module setting might be considered.

@susnux
susnux requested a review from shellscape as a code owner March 10, 2023 22:26
susnux added 2 commits April 6, 2023 10:38
This adds a test case for resolving types with node ESM `exports` feature
and `compilerOptions.moduleResolution` option configured.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux
susnux requested a review from RebeccaStevens April 6, 2023 08:39
@susnux

susnux commented May 12, 2023

Copy link
Copy Markdown
Contributor Author

Anything I can help with to get this merged?

@shellscape
shellscape merged commit eb0cfe0 into rollup:master May 12, 2023
@shellscape

Copy link
Copy Markdown
Collaborator

Time is super short right now. Thanks for the ping.

@susnux
susnux deleted the fix/typescript-moduleresolution branch May 12, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler Option moduleResolution is ignored and only dependend on module type

5 participants